Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix document build #13927

Merged
merged 2 commits into from
Jan 18, 2019
Merged

Fix document build #13927

merged 2 commits into from
Jan 18, 2019

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Jan 18, 2019

Description

This PR removes MKL-DNN from document build and reverts #13887 to re-enable website testing.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@TaoLv TaoLv requested review from aaronmarkham, marcoabreu and KellenSunderland and removed request for aaronmarkham January 18, 2019 12:06
@TaoLv TaoLv added CI pr-awaiting-review PR is waiting for code review labels Jan 18, 2019
@larroy
Copy link
Contributor

larroy commented Jan 18, 2019

Does it fix the issues with the website build?

aaronmarkham
aaronmarkham approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marcoabreu marcoabreu merged commit 791c5d5 into apache:master Jan 18, 2019
@aaronmarkham aaronmarkham mentioned this pull request Jan 22, 2019
Closed
@larroy
Copy link
Contributor

larroy commented Jan 24, 2019

What was the problem? Is not clear to me what was the problem and what is it solved :-)

@aaronmarkham
Copy link
Contributor

Refer to #13875
The docs build process uses Python's subprocess, and for some reason, when MXNet is built with MKL-DNN, this no longer works.

@TaoLv
Copy link
Member Author

TaoLv commented Jan 25, 2019

Thank you @aaronmarkham for linking the issue here. I would like to explain a little more. @larroy

Document build enabled MKL-DNN since MKL-DNN backend became default on the master branch and Intel OMP would be used then. I guess the issue is related to fork() in Intel OMP and it can be mitigated by setting KMP_INIT_AT_FORK as what we proved in the issue. Since MKL-DNN backend is not really used in document build so I just disable it in this PR and it will also help to reduce the build time for it.

jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Jan 27, 2019
@TaoLv
Fix document build (apache#13927)
6a4dc19 
* fix doc build

* Revert "Temporarily disable website testing (apache#13887)"

This reverts commit 9d42812.
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@TaoLv @stephenrawls
Fix document build (apache#13927)
8d2d318 
* fix doc build

* Revert "Temporarily disable website testing (apache#13887)"

This reverts commit 9d42812.
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@TaoLv
Fix document build (apache#13927)
48e74b1 
* fix doc build

* Revert "Temporarily disable website testing (apache#13887)"

This reverts commit 9d42812.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronmarkham aaronmarkham aaronmarkham approved these changes

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@KellenSunderland KellenSunderland Awaiting requested review from KellenSunderland

Assignees
No one assigned
Labels
CI pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TaoLv @larroy @aaronmarkham @marcoabreu